Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plug memory leaks from failed connections #144

Merged
merged 2 commits into from
Jan 4, 2024
Merged

Plug memory leaks from failed connections #144

merged 2 commits into from
Jan 4, 2024

Conversation

jhawthorn
Copy link
Member

Under a couple conditions we could leak the internal buffer->buff buffer or a trilogy_sock_t before it was attached to the client.

These were found using RUBY_FREE_AT_EXIT=1 and ASAN/LSAN.

I made it supported to call trilogy_free multiple times on the same connection.

@jhawthorn jhawthorn merged commit 46af52f into trilogy-libraries:main Jan 4, 2024
12 checks passed
@jhawthorn jhawthorn deleted the memory_leak_fixes branch January 4, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jhawthorn