Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Docker build args for CI matrix; remove Ruby 1.9 tests; change base option to Ruby 3.3 #152

Merged
merged 1 commit into from
Jan 24, 2024
Merged

Fix Docker build args for CI matrix; remove Ruby 1.9 tests; change base option to Ruby 3.3 #152

merged 1 commit into from
Jan 24, 2024

Conversation

bensheldon
Copy link
Contributor

@bensheldon bensheldon commented Jan 24, 2024 •
edited
Loading

Fixes #137

I couldn't find a working formula for Ruby 1.9.

@bensheldon bensheldon changed the title Fix Docker build args for CI matrix; remove Ruby 1.9 tests Fix Docker build args for CI matrix; remove Ruby 1.9 tests; change base option to Ruby 3.3 Jan 24, 2024
@bensheldon bensheldon marked this pull request as ready for review January 24, 2024 22:40
composerinteralia
composerinteralia approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@composerinteralia composerinteralia left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we'll need to update the required builds to match. I removed all the outdated ones so you can get a green checkmark. I updated the required builds to match.

@composerinteralia composerinteralia merged commit a4283f3 into main Jan 24, 2024
14 checks passed
@composerinteralia composerinteralia deleted the docker-args branch January 24, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@composerinteralia composerinteralia composerinteralia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI for old Rubies doesn't work correctly
2 participants
@bensheldon @composerinteralia