Create and delete auth users in tests #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eileencodes
force-pushed
the
create-auth-users
branch
4 times, most recently
from
a5660de to
6d7dbff
Compare
In local dev, if you didn't manually create these users, the tests would fail. This refactors the tests to add a new method that will create the user with the right auth plugin and then delete it at the end. I've also deleted the docker entrypoint sql scripts because now we're creating the users.
eileencodes
force-pushed
the
create-auth-users
branch
from
6d7dbff to
717c7cb
Compare
matthewd
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In local dev, if you didn't manually create these users, the tests would fail. This refactors the tests to add a new method that will create the user with the right auth plugin and then delete it at the end.