Fix max_allowed_packet math #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit our `max_allowed_packed` would fail any time the `len` of the data being written to the buffer was itself greater than the configured `max_allowed_packet`. This is because both the `len` and the `max_allowed_packet` (aka `builder->packet_max_length`) are unsigned (`size_t`). This commit bypasses the problem by adding to the left side instead of subtracting from the right.
jhawthorn
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit our
max_allowed_packedwould fail any time thelenof the data being written to the buffer was itself greater than the configuredmax_allowed_packet.This is because both the
lenand themax_allowed_packet(akabuilder->packet_max_length) are unsigned (size_t).This commit bypasses the problem by adding to the left side instead of subtracting from the right.