Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: usePhoneInput result not in national format (#84) #85

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

trinhthinh388
Copy link
Owner

  • fix: usePhoneInput result not in national format

  • feat: updated use phone input hook

  • chore: pumped version

Closes #

📝 Description

Add a brief description

⛳️ Current behavior (updates)

Please describe the current behavior that you are modifying

🚀 New behavior

Please describe the behavior or changes this PR adds

💣 Is this a breaking change (Yes/No):

📝 Additional Information

* fix: usePhoneInput result not in national format

* feat: updated use phone input hook

* chore: pumped version
@trinhthinh388 trinhthinh388 self-assigned this Mar 5, 2024
Copy link

vercel bot commented Mar 5, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-awesome-components-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 5, 2024 3:50am

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 63.46154% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 94.79%. Comparing base (8083523) to head (8f6ea12).
Report is 14 commits behind head on release.

Files Patch % Lines
packages/phone-input/src/hooks/usePhoneInput.tsx 56.09% 18 Missing ⚠️
...s/formatWithFixedCountry/formatWithFixedCountry.ts 90.90% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           release      #85      +/-   ##
===========================================
- Coverage   100.00%   94.79%   -5.21%     
===========================================
  Files           18       19       +1     
  Lines          323      365      +42     
  Branches        90      107      +17     
===========================================
+ Hits           323      346      +23     
- Misses           0       19      +19     
Flag Coverage Δ
PhoneInput 89.61% <63.46%> (-10.39%) ⬇️
useBreakpoint 100.00% <ø> (ø)
useClickOutside 100.00% <ø> (ø)
usePreserveInputCaretPosition 100.00% <ø> (ø)
usePrevious 100.00% <ø> (ø)
useSelectionRange 100.00% <ø> (ø)
useToggle 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trinhthinh388 trinhthinh388 merged commit 1058df3 into release Mar 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants