-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow all Kerberos principals to issue renewable tickets #162
Conversation
907c1f6
to
1ea0449
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rebase and also add these changes in the new hdp3.1-hive-kerberized-2
image?
3e7ed34
to
5ebf902
Compare
In next commit we'll archive the cdh5.12 images which have same names as the existing archived images.
5ebf902
to
784ddc9
Compare
Without this change if the krb5.conf is configured to issue renewable tickets by adding a non-zero `renew_lifetime` entry the JDK runs into errors like RuntimeException: LoginException: Message stream modified (41) This is related to the JDK bug https://bugs.openjdk.java.net/browse/JDK-8131051 and can be worked around by configuring the principals differently.
784ddc9
to
a7e2c80
Compare
Thanks for archiving old images - less to build and release |
@@ -10,57 +10,23 @@ | |||
# See the License for the specific language governing permissions and | |||
# limitations under the License. | |||
|
|||
FROM testing/centos6-oj8:unlabelled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should just delete these. They're archived in the git commit history. IIUC, the contents of the archived
dir is a reference for the images we can only rebuild using previous versions, where original repositories are no longer available. If we remove them, we don't need the references either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think that's exactly the case. Any image we are no longer using went to archived
. See example dns
and phoenix4
and all the centos
based images.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do agree that we could just delete instead of keeping the archived
folder around but I consider that to be out of scope for this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no point in keeping unused images there, that's what git is for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll submit a follow-up PR.
Without this change if the krb5.conf is configured to issue renewable tickets by adding a non-zero
renew_lifetime
entry the JDK runs into errors likeThis is related to the JDK bug
https://bugs.openjdk.java.net/browse/JDK-8131051 and can be worked around by configuring the principals differently.