Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Free up some disk space on the runner before doing a release #176

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

nineinchnick
Copy link
Member

Another attempt (after #174) to make more space for building all images during the release. This should free up more than 10GB.

Reference: actions/runner-images#2840 (comment)

@nineinchnick
Copy link
Member Author

We'll be able to remove some of the images soon, but we need to do a release with the new hdp3.1-hive-kerberized-2 image first.

@nineinchnick
Copy link
Member Author

My other idea is to untag some of the intermediate images (otherwise unused) before calling docker system prune, that would be the last resort.

@hashhar
Copy link
Member

hashhar commented Sep 7, 2023

what sequence do we follow?

do we:

build all
push all

or can we do:

for image in images:
build image
push image
prune
done

@nineinchnick
Copy link
Member Author

We build all and then push all. This at least allows avoiding partial releases, where some images would fail to build. I'm not sure pruning is even enough. If we'll be able to remove some images soon, I don't really want to change how we do releases.

@wendigo wendigo merged commit 43f5a64 into trinodb:master Sep 7, 2023
15 of 16 checks passed
@hashhar
Copy link
Member

hashhar commented Sep 8, 2023

seems to have worked. Thanks @wendigo for kicking the release and thanks @nineinchnick for this fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants