Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from CentOS to Alma Linux 9 #202

Merged
merged 1 commit into from
Jul 7, 2024

Conversation

Praveen2112
Copy link
Member

No description provided.

@cla-bot cla-bot bot added the cla-signed label Jul 2, 2024
@Praveen2112 Praveen2112 force-pushed the praveen/centos_migration branch 2 times, most recently from b32a99b to 04e2f77 Compare July 4, 2024 08:05
kokosing
kokosing previously approved these changes Jul 4, 2024
@Praveen2112
Copy link
Member Author

The PR is not ready

@kokosing kokosing dismissed their stale review July 4, 2024 11:40

Approval was premature

@Praveen2112
Copy link
Member Author

I think we fixed it for all images - Will cleanup this code a bit

@wendigo
Copy link
Contributor

wendigo commented Jul 4, 2024

@Praveen2112 ship it

@Praveen2112
Copy link
Member Author

I'll do some cleanup and merge it. Thanks for the review

@wendigo wendigo marked this pull request as ready for review July 4, 2024 13:01
@Praveen2112
Copy link
Member Author

The hive failure looks like a legit one

@Praveen2112 Praveen2112 force-pushed the praveen/centos_migration branch 2 times, most recently from 18b7ec9 to 023e80c Compare July 5, 2024 07:43
@Praveen2112
Copy link
Member Author

Running PTs for additional validation - Found a few failures - fixing them.

Copy link
Member

@kokosing kokosing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@@ -17,6 +17,10 @@ FROM ghcr.io/trinodb/testing/hdp3.1-hive:38

COPY ./files /
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this image?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use them for HiveHadoop image

@@ -11,7 +11,7 @@
# limitations under the License.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need this image?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still use them for phoenix connector

@Praveen2112 Praveen2112 merged commit 7e3bc50 into trinodb:master Jul 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants