Fixed Issue #27. #28
Open
Fixed Issue #27. #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uding: explicit default val for `json_result` & a py3-compat rawstring error.
Fix 1: Replaced the PyMsCognitiveSearch() arg ==> custom_params={} to custom_params=None + an if/else check. Reasoning: Dicts are mutable and default argument values are evaluated only once at function definition time, which means that modifying the default value of the argument will affect all subsequent calls of the __init__ function for PyMsCognitiveSearch(). See: https://docs.python.org/3.4/tutorial/controlflow.html#default-argument-values & scroll down to `IMPORTANT WARNING:`
Fix 2: python3 compatibility. raw_input doesn't exist in python3. Added a lil baby `from sys import version_info` + if/else gate to avoid syntax errors in python3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added some explicit declarations including: explicit default val for
json_result& a py3-compat issue involving rawstrings for use in regular expressions.