Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix is_contiguous_logic issue in dlpack #668

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

wjddn279
Copy link

@wjddn279 wjddn279 commented May 20, 2024

Hello, I'm making good use of the open source you provided.
When I use it, I find an issue and fix it to contribute to your project

issue what I find

I want to use set_shared_memory_region_from_dlpack for GPU to GPU shared memory
I converted pytorch tensor to dlpack using by to_dlpack from dlpack library but it raises error in this line

# it work well
img_tensor = img_tensor_raw.resize_(target_height, target_width, 3)
cudashm.set_shared_memory_region_from_dlpack(cuda_shm_ip_handle, [img_tensor])

# it doesn't work
img_tensor = img_tensor_raw.resize_(1, target_height, target_width, 3)
cudashm.set_shared_memory_region_from_dlpack(cuda_shm_ip_handle, [img_tensor])

although I make pytorch tensor contiguous, after making it dlpack strides corrupts
it is known issue pytorch and the maintainer says it is not an issue but logic for preventing another issue.
So to_dlpack make stride in tensor's dimension shape is 1 just 1

so, I fix is_contiguous logic to skip contiguous checking when shape is 1 and it work well in my code.
If the contribution process is in the project, I will follow it.
thanks

@wjddn279
Copy link
Author

wjddn279 commented May 20, 2024

The problem I've had is the same problem as this one #536
This PR can resolve the issue without lower version of pytorch below 1.12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant