Rename model config util config change require reload function

triton-inference-server · Aug 16, 2024 · e6da04c · e6da04c
1 parent 3d2f5c3
commit e6da04c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/model_config_utils.cc b/src/model_config_utils.cc
@@ -2432,7 +2432,7 @@ TritonToDataType(const TRITONSERVER_DataType dtype)
 }
 
 bool
-EquivalentInNonInstanceGroupAndNonVersionPolicyConfig(
+ConfigChangeRequiresReload(
     const inference::ModelConfig& old_config,
     const inference::ModelConfig& new_config)
 {
@@ -2441,7 +2441,7 @@ EquivalentInNonInstanceGroupAndNonVersionPolicyConfig(
       old_config.descriptor()->FindFieldByLowercaseName("instance_group"));
   pb_diff.IgnoreField(
       old_config.descriptor()->FindFieldByLowercaseName("version_policy"));
-  return pb_diff.Compare(old_config, new_config);
+  return !pb_diff.Compare(old_config, new_config);
 }
 
 bool

diff --git a/src/model_config_utils.h b/src/model_config_utils.h
@@ -292,10 +292,10 @@ inference::DataType TritonToDataType(const TRITONSERVER_DataType dtype);
 /// configs are equivalent.
 /// \param old_config The old model config.
 /// \param new_config The new model config.
-/// \return True if the model configs are equivalent in all non instance group
-/// and non version policy settings. False if they differ in non instance group
+/// \return False if the model configs are equivalent in all non instance group
+/// and non version policy settings. True if they differ in non instance group
 /// and non version policy settings.
-bool EquivalentInNonInstanceGroupAndNonVersionPolicyConfig(
+bool ConfigChangeRequiresReload(
     const inference::ModelConfig& old_config,
     const inference::ModelConfig& new_config);
 

diff --git a/src/model_repository_manager/model_lifecycle.cc b/src/model_repository_manager/model_lifecycle.cc
@@ -490,7 +490,7 @@ ModelLifeCycle::AsyncLoad(
         // be completed with a simple config update.
         if (!serving_model->is_ensemble_ &&
             !prev_timestamp.IsModelVersionModified(curr_timestamp, version) &&
-            EquivalentInNonInstanceGroupAndNonVersionPolicyConfig(
+            !ConfigChangeRequiresReload(
                 serving_model->model_config_, model_config)) {
           // Update the model
           model_info = serving_model.get();