Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Metrics API enhanced for Failure counters (#377) #378

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

indrajit96
Copy link
Contributor

Enhances existing metrics API to incorporate failure and failure counts in inference requests

Enhances existing metrics API to incorporate failure and failure counts in inference requests
---------

Co-authored-by: Kevin Wang <kevinwa@ipp1-0780.ipp1u1.colossus.nvidia.com>
Co-authored-by: krishung5 <krish@nvidia.com>
@indrajit96 indrajit96 requested a review from mc-nv July 12, 2024 01:36
@mc-nv mc-nv requested review from fpetrini15 and pvijayakrish July 12, 2024 17:52
Copy link
Contributor

@fpetrini15 fpetrini15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read through the comments in the original PR, this LGTM.

@mc-nv
Copy link
Contributor

mc-nv commented Jul 15, 2024

Read through the comments in the original PR, this LGTM.

This change will require to re-stage all the containers

@mc-nv mc-nv merged commit 03b81c0 into r24.07 Jul 15, 2024
1 check passed
@mc-nv mc-nv deleted the indrajit-metrics-r24.07-cp branch July 15, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants