feat: Add parameters support to InferResponse #394
+176
−83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 tasks
kthui
force-pushed
the
jacky-py-res-param
branch
from
7b63cc9 to
c3a9c1b
Compare
rmccorm4
reviewed
Jan 24, 2025
| @@ -58,6 +60,12 @@ InferResponse::OutputTensors() | |||
| return output_tensors_; | |||
| } | |||
|
|
|||
| std::string& | |||
There was a problem hiding this comment.
Should it be mutable or const?
rmccorm4
reviewed
Jan 24, 2025
| const bool is_last_response = true, void* id = nullptr); | ||
| std::vector<std::shared_ptr<PbTensor>>& OutputTensors(); | ||
| std::string& Parameters(); |
There was a problem hiding this comment.
Looks like this parameters string is expected to be JSON serializable (unless empty string?) - can you add some docstrings describing that expectation?
rmccorm4
reviewed
Jan 24, 2025
There was a problem hiding this comment.
Can we add a README section for response parameters similar to the one for request parameters? https://github.com/triton-inference-server/python_backend?tab=readme-ov-file#inference-request-parameters
There was a problem hiding this comment.
Yes, it is added. 816d4ac
rmccorm4
reviewed
Jan 24, 2025
src/pb_stub.cc
Outdated
Comment on lines
1884
to
1886
| if (!py::isinstance<py::bool_>(pair.second) && | ||
| !py::isinstance<py::int_>(pair.second) && | ||
| !py::isinstance<py::str>(pair.second)) { |
There was a problem hiding this comment.
Should we have any protection against modifying reserved parameter keys such as triton_final_response from user-code?
* Infer response to track parameters * Add parameters to binding infer response * Rank parameters argument up among InferResponse constructor arguments * Add setting parameters to Triton response * Send response parameters only on non-error * Fix double declaration * Unify py dictionary parameters to json str
kthui
force-pushed
the
jacky-py-res-param
branch
from
c3a9c1b to
816d4ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Add support for setting response parameters in regular and decoupled Python backend model response(s).
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
triton-inference-server/server#7964
Where should the reviewer start?
Start with the test cases on the related server PR, and then
pb_stub.cc->infer_response.cc->python_be.cc.Test plan:
New tests are added to the related server PR.
Caveats:
Responses to BLS models are not populated with the response parameters, if any. (DLIS-7864)
Background
N/A
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
N/A