build: RHEL 8 Compatibility #7519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
More general capture of Linux Distros tritonserver compiling except for --filesystem=gcs and --filesystem=s3 adding sbsa installation for dcgm updating RUNPATH directory for tritonserver executable cleanup removed build_ubuntu and updated build.py
* Merge ORT RHEL changes Into Kyle's RHEL dev
nv-kmcgill53
added
the
module: platforms
fpetrini15
reviewed
Aug 12, 2024
mc-nv
reviewed
Aug 13, 2024
mc-nv
previously approved these changes
Aug 14, 2024
mc-nv
reviewed
Aug 14, 2024
mc-nv
previously approved these changes
Aug 14, 2024
fpetrini15
reviewed
Aug 15, 2024
Co-authored-by: Francesco Petrini <francescogpetrini@gmail.com>
fpetrini15
approved these changes
Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
This PR adds the following:
--no-container-buildsince Triton Inference Server doesn't publish a base container with which to usetarget_platform()method inbuild.pyto distinguish between debian and rhel-like systems.CMakeLists.txtfiles to correctly point at thelib64directories on rhel-like systems.Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
triton-inference-server/core#387
triton-inference-server/third_party#59
Where should the reviewer start?
build.py is the meat of this PR. The CMakeLists.txt files are the same changes which are needed in the Related PRs section.
Test plan:
No new e2e tests were added to this repository
Caveats: N/A
Background
This is a requested feature from users of Triton, check with Product team for specifics.
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)