Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Test histogram metric #7525

Conversation

yinggeh
Copy link
Contributor

@yinggeh yinggeh commented Aug 14, 2024

What does the PR do?

Tests histogram metric in custom_metrics.

Checklist

  • PR title reflects the change and is of format <commit_type>: <Title>
  • Changes are described in the pull request.
  • Related issues are referenced.
  • Populated github labels field
  • Added test plan and verified test passes.
  • Verified that the PR passes existing CI.
  • Verified copyright is correct on all changed files.
  • Added succinct git squash message before merging ref.
  • All template sections are filled out.
  • Optional: Additional screenshots for behavior/output changes with before/after.

Commit Type:

Check the conventional commit type
box here and add the label to the github PR.

  • test

Related PRs:

triton-inference-server/vllm_backend#56
triton-inference-server/python_backend#374
triton-inference-server/core#386

Where should the reviewer start?

n/a

Test plan:

n/a

  • CI Pipeline ID:
    17487728

Caveats:

n/a

Background

Customer requested histogram metrics from vLLM.

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

n/a

@yinggeh yinggeh self-assigned this Aug 14, 2024
@yinggeh yinggeh added the PR: test Adding missing tests or correcting existing test label Aug 14, 2024
@yinggeh yinggeh changed the title test: Add histogram metric type test: Test histogram metric Aug 14, 2024
@yinggeh yinggeh force-pushed the yinggeh-DLIS-7113-support-histogram-metric-type branch from 3548e05 to ef797b3 Compare August 15, 2024 08:53
@yinggeh yinggeh changed the base branch from main to yinggeh-DLIS-7061-add-vllm-metrics August 15, 2024 22:23
Base automatically changed from yinggeh-DLIS-7061-add-vllm-metrics to main August 16, 2024 03:35
@yinggeh yinggeh changed the base branch from main to yinggeh-DLIS-7061-add-vllm-metrics August 16, 2024 18:43
@yinggeh yinggeh merged commit d7fea1a into yinggeh-DLIS-7061-add-vllm-metrics Aug 16, 2024
3 checks passed
@yinggeh yinggeh deleted the yinggeh-DLIS-7113-support-histogram-metric-type branch August 16, 2024 21:16
@yinggeh yinggeh restored the yinggeh-DLIS-7113-support-histogram-metric-type branch August 16, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: test Adding missing tests or correcting existing test
Development

Successfully merging this pull request may close these issues.

2 participants