docs: Load new model version should not reload loaded existing model version(s) #7537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnshah1
reviewed
Aug 16, 2024
| @@ -236,6 +236,11 @@ in-flight sequence(s) will be routed to the same model instance for processing. | |||
| It is currently the responsibility of the user to ensure any in-flight | |||
| sequence(s) are completed before reloading a sequence model. | |||
|
|
|||
| * Starting from r24.09, if the version policy on the model configuration is | |||
There was a problem hiding this comment.
how difficult is it to provide an example?
No fault here - but I don't quite follow the change / not sure others would understand.
If it's already considered 'expected' behavior - maybe we can just update the descriptions below ...
|
Discussed offline that we are ok with not having a docs for this change, because not reloading an unchanged model version is expected and this change can be mentioned in the release note, so closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do?
Document any loaded and unmodified model version(s) will not be reloaded upon changes to other model versions.
Checklist
<commit_type>: <Title>Commit Type:
Check the conventional commit type
box here and add the label to the github PR.
Related PRs:
#7527
triton-inference-server/core#388
Where should the reviewer start?
Start with the core PR.
Test plan:
This is a documentation change, so any testing will be covered by related PRs linked.
Caveats:
N/A
Background
N/A
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
N/A