Renaming the tensors and removing tools #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nnshah1
reviewed
Oct 10, 2023
| if isinstance(prompt, bytes): | ||
| prompt = prompt.decode("utf-8") | ||
| stream = pb_utils.get_input_tensor_by_name(request, "STREAM").as_numpy()[0] | ||
| stream = pb_utils.get_input_tensor_by_name(request, "stream").as_numpy()[0] |
There was a problem hiding this comment.
one other change to be picked up - making stream an optional param:
https://github.com/triton-inference-server/tutorials/pull/58/files
There was a problem hiding this comment.
Its already included in the changes.
There was a problem hiding this comment.
There was a problem hiding this comment.
@tanmayv25 but don't we need to check here if it is included?
Suggested change
| stream = pb_utils.get_input_tensor_by_name(request, "stream").as_numpy()[0] | |
| stream = pb_utils.get_input_tensor_by_name(request, "stream") | |
| if stream: | |
| stream = stream.as_numpy()[0] | |
| else: | |
| stream = False |
There was a problem hiding this comment.
Good catch! I missed it.
Probably one more test case to include in our CI tests.
@pskiran1 ^^^
dyastremsky
approved these changes
Oct 10, 2023
|
Great changes. Fantastic work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes are being cherry-picked from here: triton-inference-server/tutorials#59