Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump julia-actions/setup-julia from 1 to 2 #122

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 1, 2024

Bumps julia-actions/setup-julia from 1 to 2.

Release notes

Sourced from julia-actions/setup-julia's releases.

v2.0.0 - Update to Node20

What's Changed

Note the rationale for the breaking change was discussed in julia-actions/setup-julia#209

Dependencies and misc

New Contributors

Full Changelog: julia-actions/setup-julia@v1.9.6...v2.0.0

v1.9.6: Fix Apple Silicon installation

What's Changed

Deps & CI

New Contributors

Full Changelog: julia-actions/setup-julia@v1.9.5...v1.9.6

v1.9.5: Maintain mtime of julia build to avoid re-precompilation

A big part of fixing JuliaLang/julia#50667 for julia <1.11 as maintaining the mtime of the julia source files means cached /compiled caches won't be invalidated in new runs where julia has been reinstalled.

What's Changed

Dep updates

... (truncated)

Commits
  • f225878 Add production dependencies & build
  • b96a572 Bump the version number to 2.0.0 in package.json and package-lock.json ...
  • 437a175 update to node20 (#209)
  • e9d953d Bump @​types/node from 20.11.16 to 20.11.30 (#226)
  • 4190528 Bump @​types/semver from 7.5.6 to 7.5.8 (#222)
  • 9acd04f Bump nock from 13.5.1 to 13.5.4 (#224)
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Apr 1, 2024
Bumps [julia-actions/setup-julia](https://github.com/julia-actions/setup-julia) from 1 to 2.
- [Release notes](https://github.com/julia-actions/setup-julia/releases)
- [Commits](julia-actions/setup-julia@v1...v2)

---
updated-dependencies:
- dependency-name: julia-actions/setup-julia
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/github_actions/julia-actions/setup-julia-2 branch from fcb41a5 to a3c56be Compare April 2, 2024 07:35
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the action should not affect us. It looks like CI is also fine, only the codecov action fails - which is quite annoying...

@ranocha ranocha merged commit 65424b4 into main Apr 2, 2024
5 of 13 checks passed
@ranocha ranocha deleted the dependabot/github_actions/julia-actions/setup-julia-2 branch April 2, 2024 11:46
@JoshuaLampert
Copy link
Member

It looks like CI is also fine, only the codecov action fails - which is quite annoying...

According to the README of the codecov-action this is because the CODECOV_TOKEN was not added to the dependabot secrets. I just added the secret. So let's see if codecov works for the next dependabot PR in a month.

@JoshuaLampert
Copy link
Member

JoshuaLampert commented Apr 2, 2024

Ok, I just made some experiments in another repo. Without having CODECOV_TOKEN in the dependabot secrets I had the same error as here. Then I added the token, reran the tests, and then it worked. So it seems that the CODECOV_TOKEN just needs to be added to the "Dependabot secrets" in the settings of the repo (under "Secrets and Variables"). Thus, I recommend doing this for the other repos in the trixi-framework (and beyond) as well.

@JoshuaLampert
Copy link
Member

So let's see if codecov works for the next dependabot PR in a month.

Actually, we don't need to wait for a month. This PR #123 is the proof that it works. You can also trigger dependabot manually.

@ranocha
Copy link
Member

ranocha commented Apr 2, 2024

Nice, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants