CompatHelper: add new compat entry for Downloads at version 1 for package test, (keep existing compat) #1693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
…kage test, (keep existing compat)
github-actions
bot
force-pushed
the
compathelper/new_version/2023-10-29-00-06-21-120-02194112554
branch
from
4dd298a
to
cc608d8
Compare
ranocha
reviewed
Oct 30, 2023
ranocha
approved these changes
Oct 30, 2023
And some Flux.jl stuff.... Let's wait for an answer in JuliaRegistries/TagBot#292 before deciding how to proceed with this |
auto-merge was automatically disabled
October 30, 2023 07:22
Pull request was converted to draft
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1693 +/- ##
==========================================
+ Coverage 96.14% 96.19% +0.05%
==========================================
Files 430 430
Lines 34474 34456 -18
==========================================
Hits 33142 33142
+ Misses 1332 1314 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ranocha
deleted the
compathelper/new_version/2023-10-29-00-06-21-120-02194112554
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request sets the compat entry for the
Downloadspackage to1for package test.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
Note: Consider registering a new release of your package immediately after merging this PR, as downstream packages may depend on this for tests to pass.