Added discrete movement and utility to build mission from an XML file #180
+425
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe discrete movement test failed because trueagi-io/Vereya#81 is not accepted yet |
noskill
reviewed
Dec 26, 2024
| import tagilmo.utils.mission_builder as mb | ||
| from .xml_util import remove_namespaces | ||
|
|
||
| def _createAbout(aboutRoot = None): |
There was a problem hiding this comment.
I think we can move these helper functions into corresponding classes, e.g. createAbout into About.from_xml, _createAgentSection into AgentSection.from_xml etc..
@CICS-Oleg what do you think?
There was a problem hiding this comment.
Done. Also I added new argument into MissionXML constructor: path to the XML file, so that mission can be built at initialization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mc.discreteMove().load_mission()the mission can be built from given XML file. The functionality was tested on cliff walking tutorial from project malmo https://github.com/microsoft/malmo/blob/master/Malmo/samples/Python_examples/tutorial_6.xml@CICS-Oleg