Skip to content

Commit

Permalink
NAS-132599 / 25.04 / Increase ES24n import timeout (#14975)
Browse files Browse the repository at this point in the history
* Increase ES24n timeout in vrrp_master

* Add logging
  • Loading branch information
bmeagherix authored Nov 18, 2024
1 parent ff029ac commit 16cccbe
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 2 deletions.
10 changes: 8 additions & 2 deletions src/middlewared/middlewared/plugins/failover_/event.py
Original file line number Diff line number Diff line change
Expand Up @@ -389,15 +389,21 @@ def vrrp_master(self, job, fobj, ifname, event):
try:
# Request fenced_reload just in case the job does not complete in time
jbof_job = self.run_call('jbof.configure_job', True)
jbof_job.wait_sync(timeout=10)
jbof_job.wait_sync(timeout=60)
if jbof_job.error:
logger.error(f'Error attaching JBOFs: {jbof_job.error}')
elif jbof_job.result['failed']:
logger.error(f'Failed to attach JBOFs:{jbof_job.result["message"]}')
else:
logger.info(jbof_job.result['message'])
except TimeoutError:
logger.error('Timed out attaching JBOFs - will continue in background')
logger.error('Timed out attaching JBOFs. Retrying')
try:
jbof_job.wait_sync(timeout=60)
except TimeoutError:
logger.error('Timed out attaching JBOFs.')
else:
logger.info('Done bring up of NVMe/RoCE')
except Exception:
logger.error('Unexpected error', exc_info=True)
else:
Expand Down
1 change: 1 addition & 0 deletions src/middlewared/middlewared/plugins/jbof/crud.py
Original file line number Diff line number Diff line change
Expand Up @@ -852,6 +852,7 @@ async def configure_jbof(self, node, shelf_index):
interface['prefixlen'],
interface['mtu'])
jbof_ips.append(jbof_static_ip_from_initiator_ip(interface['address']))
self.logger.debug(f'Configured {interface["address"]} for NVMe/RoCE')

# Next do the NVMe connect
# Include some retry code, but expect it won't get used.
Expand Down

0 comments on commit 16cccbe

Please sign in to comment.