Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-132742 / 24.10.1 / fix key collision in zpool.status (by yocalebo) #15047

Merged
merged 2 commits into from
Nov 26, 2024

Conversation

bugclerk
Copy link
Contributor

@bugclerk bugclerk commented Nov 26, 2024

Someone named one of their zpools disks..... A strange zpool name but it caused a key collision in zpool.status. Place all zpools underneath a top-level pools key to prevent this scenario.

Original PR: #15043
Jira URL: https://ixsystems.atlassian.net/browse/NAS-132742

(cherry picked from commit 4595210)
@yocalebo yocalebo marked this pull request as ready for review November 26, 2024 20:52
@yocalebo yocalebo merged commit 7d63916 into release/24.10.1 Nov 26, 2024
1 of 2 checks passed
@yocalebo yocalebo deleted the NAS-132742-24.10.1 branch November 26, 2024 20:53
@bugclerk
Copy link
Contributor Author

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Nov 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants