Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add Device.test_polling_time #78

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

Gigahawk
Copy link
Contributor

Fix #77

@ralequi
Copy link
Collaborator

ralequi commented Dec 21, 2023

Hi, first of all, sorry for the delay.

I've a question: do you have a complete output that contains the data on the issue #77 ?

There is no test for your new functionality so there is no way to check if it works or when it may get broken. ¿could you provide one? It's not necessary to add directly to test folder if it is too confusing for you, but at least the text here so I could add & check it

@ralequi ralequi self-assigned this Dec 21, 2023
@ralequi ralequi added enhancement needs more info More info is required to continue labels Dec 21, 2023
@Gigahawk
Copy link
Contributor Author

Hi, first of all, sorry for the delay.

I've a question: do you have a complete output that contains the data on the issue #77 ?

There is no test for your new functionality so there is no way to check if it works or when it may get broken. ¿could you provide one? It's not necessary to add directly to test folder if it is too confusing for you, but at least the text here so I could add & check it

Sorry, I will look into adding a test for this

PS D:\git_WSL\smartp> smartctl -a /dev/sda
smartctl 7.4 2023-08-01 r5530 [x86_64-w64-mingw32-w10-22H2] (sf-7.4-1)
Copyright (C) 2002-23, Bruce Allen, Christian Franke, www.smartmontools.org

=== START OF INFORMATION SECTION ===
Model Family:     Seagate BarraCuda 3.5 (SMR)
Device Model:     ST4000DM004-2CV104
Serial Number:    ZFN35EWR
LU WWN Device Id: 5 000c50 0c5318569
Firmware Version: 0001
User Capacity:    4,000,787,030,016 bytes [4.00 TB]
Sector Sizes:     512 bytes logical, 4096 bytes physical
Rotation Rate:    5425 rpm
Form Factor:      3.5 inches
Device is:        In smartctl database 7.3/5528
ATA Version is:   ACS-3 T13/2161-D revision 5
SATA Version is:  SATA 3.1, 6.0 Gb/s (current: 6.0 Gb/s)
Local Time is:    Thu Dec 21 18:29:56 2023 PST
SMART support is: Available - device has SMART capability.
SMART support is: Enabled

=== START OF READ SMART DATA SECTION ===
SMART overall-health self-assessment test result: PASSED

General SMART Values:
Offline data collection status:  (0x00) Offline data collection activity
                                        was never started.
                                        Auto Offline Data Collection: Disabled.
Self-test execution status:      (   0) The previous self-test routine completed
                                        without error or no self-test has ever
                                        been run.
Total time to complete Offline
data collection:                (    0) seconds.
Offline data collection
capabilities:                    (0x73) SMART execute Offline immediate.
                                        Auto Offline data collection on/off support.
                                        Suspend Offline collection upon new
                                        command.
                                        No Offline surface scan supported.
                                        Self-test supported.
                                        Conveyance Self-test supported.
                                        Selective Self-test supported.
SMART capabilities:            (0x0003) Saves SMART data before entering
                                        power-saving mode.
                                        Supports SMART auto save timer.
Error logging capability:        (0x01) Error logging supported.
                                        General Purpose Logging supported.
Short self-test routine
recommended polling time:        (   1) minutes.
Extended self-test routine
recommended polling time:        ( 490) minutes.
Conveyance self-test routine
recommended polling time:        (   2) minutes.
SCT capabilities:              (0x30a5) SCT Status supported.
                                        SCT Data Table supported.
...

@Gigahawk
Copy link
Contributor Author

Tests updated, let me know if it's okay.

@ralequi ralequi changed the base branch from master to develop December 22, 2023 09:30
@ralequi ralequi merged commit 99c50bb into truenas:develop Dec 22, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement needs more info More info is required to continue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] - Add support for reading polling_minutes
2 participants