Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore invalid SQL Server URLs #3429

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Ignore invalid SQL Server URLs #3429

merged 1 commit into from
Nov 7, 2024

Conversation

rgmz
Copy link
Contributor

@rgmz rgmz commented Oct 16, 2024 •
edited
Loading

Description:

Reduce the number of false positives from invalid URLs. Related to #1458 (comment).

e.g.,

Found unverified result 🐷🔑❓
Verification issue: parse "sqlserver://sa:@{sql:1433?database=master&connection+timeout=5": invalid character "{" in host name
Detector Type: JDBC
Decoder Type: PLAIN
Raw result: jdbc:sqlserver://{sql
File: /tmp/clusters_client_example_test.go
Line: 203

https://github.com/Azure/azure-sdk-for-go/blob/7ea57e99feeadc51cb635d0c8f05be18cd9b2809/sdk/resourcemanager/hdinsight/armhdinsight/clusters_client_example_test.go#L1558

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@rgmz rgmz requested a review from a team as a code owner November 3, 2024 16:19
ahrav
ahrav approved these changes Nov 7, 2024
View reviewed changes
Copy link
Collaborator

@ahrav ahrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm! ❤️

pkg/detectors/jdbc/jdbc.go Outdated Show resolved Hide resolved
@ahrav ahrav merged commit 3063f63 into trufflesecurity:main Nov 7, 2024
12 checks passed
@rgmz rgmz deleted the fix/sqlserver branch November 7, 2024 21:44
@blsaccess blsaccess mentioned this pull request Nov 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrav ahrav ahrav approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rgmz @ahrav