Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed verification endpoint and verification logic for brand fetch #3470

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

fix: fixed verification endpoint and verification logic for brand fetch #3470

wants to merge 7 commits into from

Conversation

sahil9001
Copy link
Contributor

Description:

Fixes #3469 .

ssilare@Sahils-MacBook-Air trufflehog %    go test ./pkg/detectors/brandfetch -tags=detectors

ok      github.com/trufflesecurity/trufflehog/v3/pkg/detectors/brandfetch       3.096s

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

kashifkhan0771
kashifkhan0771 requested changes Oct 21, 2024
View reviewed changes
pkg/detectors/brandfetch/brandfetch.go Outdated Show resolved Hide resolved
pkg/detectors/brandfetch/brandfetch.go Outdated Show resolved Hide resolved
@sahil9001 sahil9001 requested a review from a team as a code owner October 22, 2024 12:49
kashifkhan0771
kashifkhan0771 requested changes Oct 22, 2024
View reviewed changes
pkg/engine/defaults.go Outdated Show resolved Hide resolved
@kashifkhan0771 kashifkhan0771 requested a review from a team as a code owner November 6, 2024 06:46
kashifkhan0771
kashifkhan0771 requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@kashifkhan0771 kashifkhan0771 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sahil9001 can you resolve the conflicts. Changes are approved.

@sahil9001 sahil9001 force-pushed the brandfetch-verfication-endpoint-fix branch from a212f22 to ca674ad Compare November 9, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifkhan0771 kashifkhan0771 kashifkhan0771 approved these changes

@ahrav ahrav ahrav approved these changes

@zricethezav zricethezav zricethezav approved these changes

Assignees
No one assigned
Labels
hacktoberfest-2024
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with incorrect verification endpoint and verification logic for BrandFetch
5 participants
@sahil9001 @zricethezav @ahrav @kashifkhan0771 @dustin-decker