Feat: Added ZohoCRM detector #3516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rgmz
reviewed
Oct 28, 2024
abmussani
reviewed
Oct 31, 2024
There was a problem hiding this comment.
@nabeelalam Thank you for new addition in Detectors. Along with some comments, You need to also add new detector in Defaults.go otherwise engine won't load it.
pkg/detectors/zohocrm/zohocrm.go
Outdated
Comment on lines
23
to
25
| Details map[string]interface{} `json:"details"` | ||
| Message string `json:"message"` | ||
| Status string `json:"status"` |
There was a problem hiding this comment.
Can we remove them as these 3 fields are not being used anywhere ?
There was a problem hiding this comment.
Yeah I had mapped the output, in order to add extra data in the response but it felt unnecessary. I've removed this fields.
kashifkhan0771
requested changes
Nov 5, 2024
abmussani
approved these changes
Nov 6, 2024
kashifkhan0771
approved these changes
Nov 6, 2024
rgmz
reviewed
Nov 8, 2024
pkg/detectors/zohocrm/zohocrm.go
Outdated
| } | ||
|
|
||
| func (s Scanner) Description() string { | ||
| return "Zohocrm is a blockchain development platform that provides a suite of tools and services for building and scaling decentralized applications. Zohocrm API keys can be used to access these services." |
There was a problem hiding this comment.
I don't think this is correct?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR introduces a new detector for Zoho CRM API access tokens.
For the integration test, the active
ZOHOCRMaccess token only has a 60 minute validity before becoming inactive, so an active token would have to be generated and added to the Secrets Manager for these tests to pass.Access tokens can be generated by following the following steps in the Zoho documentation:
https://www.zoho.com/accounts/protocol/oauth/self-client/authorization-code-flow.html
Checklist:
make test-community)?make lintthis requires golangci-lint)?