Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

strip symbol table and DWARF generation #3534

Merged
merged 1 commit into from
Oct 30, 2024
Merged

strip symbol table and DWARF generation #3534

merged 1 commit into from
Oct 30, 2024

Conversation

zricethezav
Copy link
Collaborator

@zricethezav zricethezav commented Oct 30, 2024 •
edited
Loading

Description:

This PR strips the symbol -s table and DWARF -w generation which are mainly used for hopping into a debugger. Using these ldflags seems like a pretty common convention when shipping release builds. This takes the existing TH binary down from 174MB to 121MB.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@zricethezav zricethezav requested a review from a team as a code owner October 30, 2024 15:56
@zricethezav zricethezav changed the title strip symbol and DWARF tables strip symbol table and DWARF generation Oct 30, 2024
@zricethezav zricethezav merged commit b6ace9d into main Oct 30, 2024
13 checks passed
@zricethezav zricethezav deleted the smaller-builds branch October 30, 2024 17:51
@blsaccess blsaccess mentioned this pull request Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahrav ahrav ahrav approved these changes

@dustin-decker dustin-decker dustin-decker approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zricethezav @dustin-decker @ahrav