Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed gitlab extradata overwriting #3537

Merged
merged 1 commit into from
Oct 31, 2024
Merged

fixed gitlab extradata overwriting #3537

merged 1 commit into from
Oct 31, 2024

Conversation

kashifkhan0771
Copy link
Contributor

@kashifkhan0771 kashifkhan0771 commented Oct 31, 2024 •
edited
Loading

Description:

The extra data is already being assigned at the top result level, directly assigning extraData map which is being returned from verification func is overwriting it.

Checklist:

  • Tests passing (make test-community)?
  • Lint passing (make lint this requires golangci-lint)?

@kashifkhan0771 kashifkhan0771 requested a review from a team as a code owner October 31, 2024 06:07
@zricethezav zricethezav merged commit bd5e287 into trufflesecurity:main Oct 31, 2024
13 checks passed
@kashifkhan0771 kashifkhan0771 deleted the fix/gitlab-extradata branch October 31, 2024 12:35
@blsaccess blsaccess mentioned this pull request Nov 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zricethezav zricethezav zricethezav approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kashifkhan0771 @zricethezav