Add GitLab shared exclusion flag #3572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcastorina
reviewed
Nov 7, 2024
| @@ -577,6 +582,7 @@ func (s *Source) getAllProjectRepos( | |||
| ListOptions: listOpts, | |||
| OrderBy: gitlab.Ptr(orderBy), | |||
| IncludeSubGroups: gitlab.Ptr(true), | |||
| WithShared: gitlab.Ptr(s.enumerateSharedProjects), | |||
There was a problem hiding this comment.
The docs indicate with_shared defaults to true. Is this config option here to disable with_shared for debug testing?
zricethezav
approved these changes
Nov 7, 2024
mcastorina
approved these changes
Nov 7, 2024
casey-tran
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We've been seeing some suspicious behavior from the GitLab API when we're scanning a very large organization that has lots of group sharing. Since reproducing the behavior in a test environment isn't really tractable, this PR adds an optional configuration flag that can be used to investigate the phenomenon in the actual environment we're seeing it in.
Checklist:
make test-community)?make lintthis requires golangci-lint)?