cleanup buf tests, known_bad_version for scalafmt

trunk-io · Nov 12, 2024 · 21fb213 · 21fb213
1 parent dcacc84
commit 21fb213
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 104 deletions.
diff --git a/linters/buf/plugin.yaml b/linters/buf/plugin.yaml
@@ -29,7 +29,7 @@ tools:
   definitions:
     - name: buf
       download: buf
-      known_good_version: 1.0.0-rc11
+      known_good_version: 1.17.0
       shims: [buf]
       health_checks:
         - command: buf --version

diff --git a/linters/buf/test_data/buf_breaking_v1.5.0_dupFile.check.shot b/linters/buf/test_data/buf_breaking_v1.5.0_dupFile.check.shot
@@ -5,35 +5,35 @@ exports[`Testing linter buf-breaking test dupFile 1`] = `
   "issues": [
     {
       "code": "COMPILE",
-      "column": "5",
+      "column": "13",
       "file": "test_data/buf_breaking.in.proto",
       "issueUrl": "https://docs.buf.build/breaking/rules#compile",
       "level": "LEVEL_HIGH",
       "line": "7",
       "linter": "buf-breaking",
-      "message": "duplicate symbol trunk.HelloWorld: already defined as message in "test_data/buf_breaking.in.proto"",
+      "message": "symbol "trunk.HelloWorld" already defined at test_data/buf_breaking.in.proto:7:13",
       "targetType": "proto",
     },
     {
       "code": "COMPILE",
-      "column": "7",
+      "column": "13",
       "file": "test_data/buf_breaking.in.proto",
       "issueUrl": "https://docs.buf.build/breaking/rules#compile",
       "level": "LEVEL_HIGH",
       "line": "8",
       "linter": "buf-breaking",
-      "message": "duplicate symbol trunk.HelloWorld.hello: already defined as field in "test_data/buf_breaking.in.proto"",
+      "message": "symbol "trunk.HelloWorld.hello" already defined at test_data/buf_breaking.in.proto:8:13",
       "targetType": "proto",
     },
     {
       "code": "COMPILE",
-      "column": "7",
+      "column": "13",
       "file": "test_data/buf_breaking.in.proto",
       "issueUrl": "https://docs.buf.build/breaking/rules#compile",
       "level": "LEVEL_HIGH",
       "line": "9",
       "linter": "buf-breaking",
-      "message": "duplicate symbol trunk.HelloWorld.world: already defined as field in "test_data/buf_breaking.in.proto"",
+      "message": "symbol "trunk.HelloWorld.world" already defined at test_data/buf_breaking.in.proto:9:13",
       "targetType": "proto",
     },
   ],

diff --git a/linters/buf/test_data/buf_breaking_v1.9.0_basic.check.shot b/linters/buf/test_data/buf_breaking_v1.9.0_basic.check.shot
diff --git a/linters/buf/test_data/buf_breaking_v1.9.0_dupFile.check.shot b/linters/buf/test_data/buf_breaking_v1.9.0_dupFile.check.shot
diff --git a/linters/scalafmt/plugin.yaml b/linters/scalafmt/plugin.yaml
@@ -46,3 +46,5 @@ lint:
         parse_regex: scalafmt ${semver}
         run: scalafmt --version
       known_good_version: 3.4.3
+      # We don't support this semver format, and it's a prerelease
+      known_bad_versions: [3.8.4-RC1]