Skip to content

Commit

Permalink
Merge pull request #12 from trussworks/jc-alarm-description
Browse files Browse the repository at this point in the history
Update alarm description for disable_or_delete_cmk
  • Loading branch information
jsclarridge committed Mar 18, 2021
2 parents ae5b527 + 5c9cf0d commit 5367232
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ jobs:
- auth:
password: $DOCKER_PASSWORD
username: $DOCKER_USERNAME
image: trussworks/circleci:efb1042e31538677779971798e0912390f699e72
image: trussworks/circleci:62e7cada934784e47333e47175be728aa3475b02
steps:
- checkout
- restore_cache:
Expand Down
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ repos:
- id: trailing-whitespace

- repo: git://github.com/igorshubovych/markdownlint-cli
rev: v0.26.0
rev: v0.27.1
hooks:
- id: markdownlint

- repo: git://github.com/antonbabenko/pre-commit-terraform
rev: v1.45.0
rev: v1.48.0
hooks:
- id: terraform_docs
- id: terraform_fmt
12 changes: 11 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,17 @@ Terraform 0.12. Pin module version to `~> 1.X`. Submit pull-requests to `terrafo
|------|---------|
| aws | >= 3.0 |

## Modules

No Modules.

## Resources

| Name |
|------|
| [aws_cloudwatch_log_metric_filter](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudwatch_log_metric_filter) |
| [aws_cloudwatch_metric_alarm](https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/cloudwatch_metric_alarm) |

## Inputs

| Name | Description | Type | Default | Required |
Expand All @@ -85,5 +96,4 @@ Terraform 0.12. Pin module version to `~> 1.X`. Submit pull-requests to `terrafo
## Outputs

No output.

<!-- END OF PRE-COMMIT-TERRAFORM DOCS HOOK -->
2 changes: 1 addition & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ resource "aws_cloudwatch_metric_alarm" "disable_or_delete_cmk" {
period = "300"
statistic = "Sum"
threshold = "1"
alarm_description = "Monitoring failed console logins may decrease lead time to detect an attempt to brute force a credential, which may provide an indicator, such as source IP, that can be used in other event correlation."
alarm_description = "Data encrypted with disabled or deleted keys will no longer be accessible."
alarm_actions = [var.alarm_sns_topic_arn]
treat_missing_data = "notBreaching"
insufficient_data_actions = []
Expand Down

0 comments on commit 5367232

Please sign in to comment.