Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/validation #84

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Feature/validation #84

wants to merge 6 commits into from

Conversation

dauphin3
Copy link
Collaborator

validation for RegisterCreateLink and RegisterDeleteLink

?TODO:
OpType -> FlatOP
op.to_type() -> op.flattened()

need to fix operations for checking leading LinkTag bytes (T + arrow symbol)


const UNICODE_NUL_STR: &str = "\u{0}";
const UNICODE_T_CHAR: &str = "\u{0}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is null, not a T…

))),
};
},
Err(_) => return Err(wasm_error!(WasmErrorInner::Guest("LinkTag format error".to_string()))),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Err(_) => return Err(wasm_error!(WasmErrorInner::Guest("LinkTag format error".to_string()))),
Err(_) => return Err(wasm_error!("LinkTag format error: {}", e)),

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where e is the original error

@dauphin3 dauphin3 linked an issue Jun 2, 2023 that may be closed by this pull request
@dauphin3 dauphin3 self-assigned this Jun 21, 2023
@dauphin3 dauphin3 marked this pull request as ready for review June 22, 2023 08:53
dauphin3 and others added 6 commits July 3, 2024 16:02
Co-authored-by: Zeek <zkringlwe@gmail.com>
Co-authored-by: Harlan T Wood <harlan@superluminal.is>
Co-authored-by: Zeek <zkringlwe@gmail.com>
Co-authored-by: Zeek <zkringlwe@gmail.com>
Co-authored-by: Zeek <zkringlwe@gmail.com>
Co-authored-by: Zeek <zkringlwe@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

on delete, validate that actionhash is a link create
2 participants