Sync upstream #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update default * default all events * wip * working test
* flags need distinct id * use anon id if distinct id does not exist
* Create android.yml * add tests to workflow * add a gradle build * maybe don't need build * clean up * spacing error * try without --tests * fix group payload test * fix builder test * test commented out middleware tests * uncomment failing test * uncomment middleware tests * ignore middleware tests
…tHog#17)" (PostHog#23) This reverts commit cf546db.
* send by default * fix test
* ci: run tests on master as well Previously we were only running on pull requests, but this means that we don't get test results for the master branch. This is a problem because we want to know if the master branch is broken before we perform a release of the App. We could enforce that all PRs must be up to date with master, but this is a bit of a pain and doesn't really solve the problem of knowing for sure that master is broken.
Co-authored-by: PostHog Github Bot <github-bot@posthog.com>
# Conflicts: # posthog/src/main/java/com/posthog/android/Persistence.java # posthog/src/main/java/com/posthog/android/PostHog.java # posthog/src/main/java/com/posthog/android/PostHogActivityLifecycleCallbacks.java # posthog/src/main/java/com/posthog/android/PostHogFeatureFlags.java # posthog/src/main/java/com/posthog/android/ValueMap.java
vcoolish
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.