Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rust/Crypto]: Disable secp256k1, nist256p1, ed25519 curves in C++ #3467

Merged
merged 3 commits into from
Oct 8, 2023

Conversation

satoshiotomakan
Copy link
Collaborator

Description

Disable secp256k1, nist256p1, ed25519, ed25519-blake2b, ed25519-cardano-extended elliptic-curves in C++ except starkex curve.
Please note that RustCrypto/k256 (secp256k1) is still used in rust/ethereum.

How to test

Run C++ tests

Types of changes

Disable the mentioned curves in PrivateKey.cpp and PublicKey.cpp, and fix NEO, Ontology tests.

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

Verified

This commit was signed with the committer’s verified signature.
satoshiotomakan Sergei Boiko

Verified

This commit was signed with the committer’s verified signature.
satoshiotomakan Sergei Boiko

Verified

This commit was signed with the committer’s verified signature.
satoshiotomakan Sergei Boiko
@Milerius Milerius merged commit 434d2a9 into dev Oct 8, 2023
12 checks passed
@Milerius Milerius deleted the s/disable-rust-crypto branch October 8, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants