Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dev] Fix Android, Kotlin release scripts #3473

Merged
merged 1 commit into from
Oct 9, 2023
Merged

[Dev] Fix Android, Kotlin release scripts #3473

merged 1 commit into from
Oct 9, 2023

Conversation

satoshiotomakan
Copy link
Collaborator

Description

Forward the version argument to the following scripts: ./tools/android-release, ./tools/android-build, ./tools/kotlin-release.

How to test

Merge and try to run releases.

Types of changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@satoshiotomakan satoshiotomakan changed the base branch from master to dev October 9, 2023 11:15
@satoshiotomakan satoshiotomakan merged commit 9f08ce0 into dev Oct 9, 2023
12 checks passed
@satoshiotomakan satoshiotomakan deleted the s/fix-android-kotlin-releases branch October 9, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Milerius Milerius Awaiting requested review from Milerius Milerius is a code owner

@lamafab lamafab Awaiting requested review from lamafab

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@satoshiotomakan