Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rust/BNB]: Move BNB Beacon chain to Rust #3589

Merged
merged 24 commits into from
Dec 13, 2023
Merged

[Rust/BNB]: Move BNB Beacon chain to Rust #3589

merged 24 commits into from
Dec 13, 2023

Conversation

satoshiotomakan
Copy link
Collaborator

@satoshiotomakan satoshiotomakan commented Dec 8, 2023 •
edited
Loading

Description

Move BNB Beacon chain to Rust.

How to test

Run Rust, C++, Android and iOS tests

Breaking Changes

  • Remove the previously deprecated TWTransactionCompilerBuildInput FFI.

TODO

  • Implement all order types
  • Implement Compiler functionality
  • Remove C++ tests

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@satoshiotomakan
[BNB]: Generate BNB Beacon chain skeleton files in Rust
a526e19
@satoshiotomakan
[BNB]: Implement BinanceAddress, add Address tests
1bdf662
@satoshiotomakan
[BNB]: Add TBinance address tests
b8257c4
@satoshiotomakan
[BNB]: Add Transaction and its encoding, prehashing
42ac3ae 
* Add Amino encoding
@satoshiotomakan
[BNB]: Sign a transaction
bbc97c5 
* TODO Add tests, handle all message types
@satoshiotomakan
[BNB]: Add a signing test
4238808
@satoshiotomakan
[BNB]: Add SendOrder, CancelOrder
aae45f2
@satoshiotomakan
[BNB]: Add Token orders
037b6fb
@satoshiotomakan
[BNB]: Add TokenBurnOrder, HTLTOrder
c845819
@satoshiotomakan
[BNB]: Add DepositHTLT
fd61b03
@satoshiotomakan
[BNB]: Add ClaimHTLTOrder, RefundHTLTOrder
2afa752
@satoshiotomakan
[BNB]: Add TransferOutOrder
293f575
@satoshiotomakan
[BNB]: Add SideChainDelegate, SideChainRedelegate, `SideChainUnde…
8867f4d 
…legate` orders
@satoshiotomakan
[BNB]: Add TimeLock, TimeRelock, TimeUnlock orders
8641124
@satoshiotomakan
[BNB]: Implement Transaction Compiler
63f33cc
@satoshiotomakan
[BNB]: Increase code coverage
62610b7
@satoshiotomakan
[BNB]: Replace C++ implementation
42a32ef
@satoshiotomakan
[BNB]: Move TX preimage implementation to JsonPreimager
b814951 
* Remove C++ Signing tests
@satoshiotomakan
[BNB]: Extend CoinEntry documentation
e6d0ed4
@satoshiotomakan
Merge branch 'master' into s/rust-bnb
0fc171e
@satoshiotomakan satoshiotomakan marked this pull request as ready for review December 11, 2023 17:28
lamafab
lamafab reviewed Dec 13, 2023
View reviewed changes
Copy link
Contributor

@lamafab lamafab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Those /// cbindgen:ignore comments are expected (for the codegen I assume), right?

@satoshiotomakan
Copy link
Collaborator Author

Unfortunately, yes

LGTM. Those /// cbindgen:ignore comments are expected (for the codegen I assume), right?

@satoshiotomakan satoshiotomakan merged commit 2a63cda into master Dec 13, 2023
13 checks passed
@satoshiotomakan satoshiotomakan deleted the s/rust-bnb branch December 13, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamafab lamafab lamafab approved these changes

@Milerius Milerius Milerius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@satoshiotomakan @Milerius @lamafab