Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rust/Greenfield]: Move BNB Greenfield to Rust #3597

Merged
merged 22 commits into from
Dec 21, 2023
Merged

[Rust/Greenfield]: Move BNB Greenfield to Rust #3597

merged 22 commits into from
Dec 21, 2023

Conversation

satoshiotomakan
Copy link
Collaborator

@satoshiotomakan satoshiotomakan commented Dec 12, 2023 •
edited
Loading

Description

Move BNB Greenfield chain to Rust.

How to test

Improvements

  • Fix Greenfield chainId value to "1017"
  • Add Greenfield mainnet transaction tests
  • Add support for multiple messages per transaction

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@satoshiotomakan
[Greenfield]: Generate Rust skeleton for BNB Greenfield
9072394
@satoshiotomakan
[Greenfield]: Add Eip712Preimager
04218b8
@satoshiotomakan
[Greenfield]: Continue implementing tx signing
b99db7a 
* Add `TxBuilder`
* TODO add `TransferOut` message
@satoshiotomakan
[Greenfield]: Small refactoring
ad597a2
@satoshiotomakan
[Greenfield]: Add a signer test, fix bugs
89b3343
@satoshiotomakan
[Greenfield]: Add support for TransferOut message
99ef08b
@satoshiotomakan
[Greenfield]: Finish implementing Signer and Compiler
d92d3db
@satoshiotomakan
Merge branch 'master' into s/rust-greenfield
94e2a17
@satoshiotomakan
[Greenfield]: Add a signing test, fix Signer
efe54f7
@satoshiotomakan
[Greenfield]: Add missing tests, mainnet as well
d1ad27b
@satoshiotomakan
[Greenfield]: Add compile test
db7dc15
@satoshiotomakan
[Greenfield]: Fix TODO
13c8cce
@satoshiotomakan
[Greenfield]: Remove C++ implementation
b095a17
@satoshiotomakan
[Greenfield]: Minor changes
cf84b8d
@satoshiotomakan
[Greenfield]: Move Cosmos protobuf directory to tw_cosmos_sdk
64df15f
@satoshiotomakan
[Greenfield]: Add fuzz test
31077de
@satoshiotomakan
[Greenfield]: Update chainId
637f35d
@satoshiotomakan
[CI] Trigger CI
bf57d74
@satoshiotomakan satoshiotomakan marked this pull request as ready for review December 19, 2023 13:25
lamafab
lamafab approved these changes Dec 20, 2023
View reviewed changes
rust/chains/tw_greenfield/fuzz/Cargo.toml
path = ".."

# Prevent this from interfering with workspaces
[workspace]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's happening here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fuzz/Cargo.toml is generated by calling cargo fuzz init command.
So this is a workaround for the tw_greenfield/fuzz to not be affected by the parent workspace.

@satoshiotomakan satoshiotomakan merged commit d2d66f2 into master Dec 21, 2023
11 checks passed
@satoshiotomakan satoshiotomakan deleted the s/rust-greenfield branch December 21, 2023 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lamafab lamafab lamafab approved these changes

@Milerius Milerius Awaiting requested review from Milerius Milerius is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@satoshiotomakan @lamafab