-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Solana]: Add a function for generating token addresses for the Token-2022 Program #4010
[Solana]: Add a function for generating token addresses for the Token-2022 Program #4010
Conversation
23f13b6
to
023ffef
Compare
Hi @satoshiotomakan, I would greatly appreciate it if you could take the time to review this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! One note only
4aeef45
to
1e5bbfc
Compare
Hi @satoshiotomakan, please let me know if there's anything else you would like me to adjust in the code. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @10gic, just realized there is no test for |
Hi @satoshiotomakan, you are always meticulous. Thanks for the reminder, I have added it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @10gic, that's because WalletCore is used by millions users, and we have high quality standards :)
you are always meticulous. Thanks for the reminder, I have added it.
@10gic, could I ask you to check your email? Looking forward to your reply |
fe93d21
to
7ae5e62
Compare
Description
There is a function to generate token addresses for the Token Program, but no function for generating token addresses for the Token-2022 Program. I added a support function to address this.
How to test
Run Rust, C++, Kotlin, Swift tests
Types of changes
Checklist
If you're adding a new blockchain