Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Solana]: Add a function for generating token addresses for the Token-2022 Program #4010

Merged

Conversation

10gic
Copy link
Contributor

@10gic 10gic commented Sep 4, 2024

Description

There is a function to generate token addresses for the Token Program, but no function for generating token addresses for the Token-2022 Program. I added a support function to address this.

How to test

Run Rust, C++, Kotlin, Swift tests

Types of changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

@10gic 10gic force-pushed the add-func-for-token-2022-address branch 2 times, most recently from 23f13b6 to 023ffef Compare September 4, 2024 09:11
@10gic
Copy link
Contributor Author

10gic commented Sep 4, 2024

Hi @satoshiotomakan, I would greatly appreciate it if you could take the time to review this pull request.

Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! One note only

rust/wallet_core_rs/src/ffi/solana/address.rs Show resolved Hide resolved
@10gic 10gic force-pushed the add-func-for-token-2022-address branch from 4aeef45 to 1e5bbfc Compare September 4, 2024 13:01
@10gic 10gic changed the title Add a function for generating token addresses for the Token-2022 Program [Solana]: Add a function for generating token addresses for the Token-2022 Program Sep 4, 2024
@10gic
Copy link
Contributor Author

10gic commented Sep 5, 2024

Hi @satoshiotomakan, please let me know if there's anything else you would like me to adjust in the code. Thank you!

satoshiotomakan
satoshiotomakan previously approved these changes Sep 5, 2024
Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@satoshiotomakan
Copy link
Collaborator

Hi @10gic, just realized there is no test for TWSolanaAddressToken2022Address function in C++. Could you please add it along with the TWSolanaAddressDefaultTokenAddress

@10gic
Copy link
Contributor Author

10gic commented Sep 6, 2024

Hi @10gic, just realized there is no test for TWSolanaAddressToken2022Address function in C++. Could you please add it along with the TWSolanaAddressDefaultTokenAddress

Hi @satoshiotomakan, you are always meticulous. Thanks for the reminder, I have added it.

Copy link
Collaborator

@satoshiotomakan satoshiotomakan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @10gic, that's because WalletCore is used by millions users, and we have high quality standards :)

you are always meticulous. Thanks for the reminder, I have added it.

@satoshiotomakan
Copy link
Collaborator

@10gic, could I ask you to check your email? Looking forward to your reply

@10gic 10gic force-pushed the add-func-for-token-2022-address branch from fe93d21 to 7ae5e62 Compare September 10, 2024 16:36
@satoshiotomakan satoshiotomakan merged commit 992b248 into trustwallet:master Sep 11, 2024
12 checks passed
@10gic 10gic deleted the add-func-for-token-2022-address branch September 24, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants