[Security]: Rename ExpandedSecretKey::sign_with_pubkey to dangerous_sign_with_pubkey
#4154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary size comparison➡️ aarch64-apple-ios: 12.30 MB ➡️ aarch64-apple-ios-sim: - 12.31 MB
+ 12.31 MB +1 KB➡️ aarch64-linux-android: 15.83 MB ➡️ armv7-linux-androideabi: - 13.50 MB
+ 13.50 MB +1 KB➡️ wasm32-unknown-emscripten: - 11.22 MB
+ 11.23 MB +1 KB |
10gic
reviewed
Dec 6, 2024
rust/tw_keypair/src/ed25519/modifications/cardano/extended_private.rs
Outdated
Show resolved
Hide resolved
10gic
reviewed
Dec 6, 2024
rust/tw_keypair/src/ed25519/modifications/cardano/extended_keypair.rs
Outdated
Show resolved
Hide resolved
…s_sign_with_pubkey`
satoshiotomakan
changed the title
ExpandedSecretKey::sign_with_pubkey unsafeExpandedSecretKey::sign_with_pubkey to dangerous_sign_with_pubkey
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The function sign_with_pubkey used in tw_keypair/src/ed25519 is vulnerable to Chalkias attack, this vulnerability allows an attacker to use the signing function with arbitrary public keys leading to the extraction of the private key.
This PR makes
ExpandedSecretKey::sign_with_pubkeyunsafe to require maintainers to pay extra attention when using it.Ref: GHSA-7g72-jxww-q9vq
How to test
Types of changes
Checklist
If you're adding a new blockchain