[Solana]: Support specifying fee payer for an encoded transaction

[10gic]

Description

Fix issue #4114

How to test

Run Rust, C++, iOS, Android tests

Types of changes

Checklist

• Create pull request as draft initially, unless its complete.
• Add tests to cover changes as needed.
• Update documentation as needed.
• If there is a related Issue, mention it in the description.

If you're adding a new blockchain

• I have read the guidelines for adding a new blockchain.

[satoshiotomakan]

Looks good! Only one note - tw_solana_transaction_add_fee_payer won't be available to be called from Kotlin, Swift, JS bindings unless we bridge it through include/TWSolanaTransaction.h

[satoshiotomakan]

Do you have a chance to make a bridge similar to

wallet-core/src/interface/TWSolanaTransaction.cpp

Lines 29 to 41 in 99b69d1

	TWString *_Nullable TWSolanaTransactionGetComputeUnitPrice(TWString *_Nonnull encodedTx) {
	auto& encodedTxRef = *reinterpret_cast<const std::string*>(encodedTx);
	Rust::TWStringWrapper encodedTxStr = encodedTxRef;
	Rust::TWStringWrapper maybePrice = Rust::tw_solana_transaction_get_compute_unit_price(encodedTxStr.get());
	if (!maybePrice) {
	return nullptr;
	}
	auto priceStr = maybePrice.toStringOrDefault();
	return TWStringCreateWithUTF8Bytes(priceStr.c_str());
	}

[10gic]

Do you have a chance to make a bridge similar to

wallet-core/src/interface/TWSolanaTransaction.cpp

Lines 29 to 41 in 99b69d1

	TWString *_Nullable TWSolanaTransactionGetComputeUnitPrice(TWString *_Nonnull encodedTx) {
	auto& encodedTxRef = *reinterpret_cast<const std::string*>(encodedTx);
	Rust::TWStringWrapper encodedTxStr = encodedTxRef;
	Rust::TWStringWrapper maybePrice = Rust::tw_solana_transaction_get_compute_unit_price(encodedTxStr.get());
	if (!maybePrice) {
	return nullptr;
	}
	auto priceStr = maybePrice.toStringOrDefault();
	return TWStringCreateWithUTF8Bytes(priceStr.c_str());
	}

Currently, I haven’t added a getter function for the fee payer. The fee payer is simply the first account in a Solana transaction, and we can easily retrieve it since we already support the Solana transaction decoder.

[10gic]

Looks good! Only one note - tw_solana_transaction_add_fee_payer won't be available to be called from Kotlin, Swift, JS bindings unless we bridge it through include/TWSolanaTransaction.h

Thanks for the reminder; I will add it later.

[satoshiotomakan]

Currently, I haven’t added a getter function for the fee payer. The fee payer is simply the first account in a Solana transaction, and we can easily retrieve it since we already support the Solana transaction decoder.

No I mean we need to have a C++ -> Rust bridge, so it can be used not only from C++ or Rust, but also from Kotlin, Swift etc

[10gic]

Hi @satoshiotomakan, I tried for a while but couldn’t run the kotlin/swift test cases locally. Could you please help trigger the CI test cases?

[satoshiotomakan]

Thanks @10gic, let's run it

[satoshiotomakan]

@10gic there is a mistake in an iOS test

[10gic]

@10gic there is a mistake in an iOS test

I have tried to fix it.