Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[THORChain]: Update chainId and rpc #4167

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

satoshiotomakan
Copy link
Collaborator

@satoshiotomakan satoshiotomakan commented Dec 13, 2024

Description

Update chainId and rpc after recent chainId update following a hardfork.
#4161

Note we haven't changed chainId in unit tests, because otherwise the transaction hashes, hence links to the successfully sent transaction won't be valid.

How to test

Types of changes

Checklist

  • Create pull request as draft initially, unless its complete.
  • Add tests to cover changes as needed.
  • Update documentation as needed.
  • If there is a related Issue, mention it in the description.

If you're adding a new blockchain

  • I have read the guidelines for adding a new blockchain.

Copy link

github-actions bot commented Dec 13, 2024

Binary size comparison

➡️ aarch64-apple-ios: 12.31 MB

➡️ aarch64-apple-ios-sim: 12.31 MB

➡️ aarch64-linux-android: 15.83 MB

➡️ armv7-linux-androideabi: 13.50 MB

➡️ wasm32-unknown-emscripten: 11.23 MB

@satoshiotomakan satoshiotomakan merged commit 33dcac8 into master Dec 18, 2024
14 checks passed
@satoshiotomakan satoshiotomakan deleted the s/thorchain-update-chain-id branch December 18, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant