Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature defaults for interactive inputs #245

Open
wants to merge 9 commits into
base: decarb-develop
Choose a base branch
from

Conversation

dewittpe
Copy link
Contributor

Two additional arguments, re #244

Prior to this change if --alt_regions was used when calling ecm_prep.py
then an use was forced into specify the breakdown interactively.  This
prevented scripting a call to ecm_prep.py with --alt_regions.

This change introduces the --alt_regions_breakdown argument which takes
an interger value.  By default it will put the user into the interactive
specification, but also allows for the user to script the call and
breakdown.
Prior to this change only an interactive session could be used to define
the adopt scn restriction value. Support for scripting was needed.

This change add the --adopt_scn_restrict_scheme argument.  Defaults to
exisiting interactive behavior but also allows for scripting of the
argument.

re trynthink#244
@jtlangevin jtlangevin force-pushed the decarb-develop branch 2 times, most recently from cd941c0 to e61f7e6 Compare December 22, 2021 19:25
@jtlangevin
Copy link
Collaborator

@dewittpe thanks for this request. I think the rationale for this adjustment makes sense, but that if we're going to implement it we should do so for all of the cmd line options that are currently interactive. Looking through the code, I believe that's the following:

adopt_scn_restrict
alt_regions
exog_hp_rates
grid_decarb
tsv_metrics

There are also a few new ones on the branch decarb-develop that may make their way into the next release. I think we should make these changes for all of those interactive options at once, here. Could that be done in a revision of this pull request?

@dewittpe
Copy link
Contributor Author

dewittpe commented Jan 6, 2022

@jtlangevin Yes, I can modify this PR. I'll make some edits ping you when the additional args have been added.

This change adds the command line args to allow for scripting the
grid_decarb options.

re tryandthink/scout#244, tryandthink/scout#245
tryandthink/scout#244, tryandthink/scout#245
* --tsv_metrics_output_type
* --tsv_metrics_hours
* --tsv_metrics_sys_shape
* --tsv_metrics_season
* --tsv_metrics_calc_type
* --tsv_metrics_day_type

re tryandthink/scout#244 tryandthink/scout#245
re tryandthink/scout#244 tryandthink/scout#245
This changes the interactive and scripting inputs for --retro_set

re tryandthink/scout#244 tryandthink/scout#245
@dewittpe
Copy link
Contributor Author

dewittpe commented Jan 7, 2022

@jtlangevin I've added arg for the other interactive sections listed and for the retro_set as well. You may want to review 0583910 with more scrutiny than the other commits in this PR as that one makes a bigger change to the code base than the others to deal with the mult_yr value for retro_sets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants