-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multi-camera support #293
Draft
aguscas
wants to merge
38
commits into
master
Choose a base branch
from
multi-camera
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Multi-camera support #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
06dab8e
to
4a13e0e
Compare
Add button to load or save the state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It still needs to be done:
Use the motion estimator when either the reference or the footage that is provided to the UI is a video. This is important since we may want to associate points from the reference and the footage from several different frames, and the camera(s) may have moved between those frames.DONENext to "Remove", add button "Ignore" (to keep those buttons but not use them). You can later "Unignore" (?) them again if you want.DONEAdd button to go to the beginning of the video in the UI, for either the reference or the footage. Would need toDONE.release()
the video andcv2.destroyAllWindows()
before creating the new video instance, initialize a new Video instance with same path, re initialize the associated MotionEstimator, re define the "video", "motion_estimator", "motion_transformation", "current_frame" in the corresponding skipper dict, remove all drawing from the canvas and draw the new image.Associate trackers (from different videos) that are close in the absolute frame. Can also use embeddings (might be useful)DONEMake demo using the UI to initialize the videos to a common frame.DONEResize images: Maybe the user should be able to resize them from the UI, maybe give an option to resize both (reference and footage) independently.DONE'save': pickle the transformation and theDONEpoints
variable. Should open a Save File Dialog'load': load a previous transformation andDONEpoints
variable to keep working on that transformation. Should be an Open File DialogDockerize the demosDONEThere is a bug in the UI whenever you try to use the file dialog more than once (segmentation fault: 11). Not much we I can do in this regard, it's a common problem with tkinter
It would be nice to solve issue 306, so that we don't run into any problem if we process avi files (here, videos been synchronized is fundamental)
Add gifs to the README