fix: add manual_json and playwright-test #269
Draft
+33
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RohittCodes
changed the title
|
i forgot to claim the bounty for #265. and the fix for it temporarily solved the issue. i.e., whenever a new snippet was created it still showed the "Unsaved changes" text. This PR solves the issues with |
seveibar
reviewed
Nov 22, 2024
| const newSnippet = snippetSchema.parse({ | ||
| ...snippet, | ||
| manual_edits_json: JSON.stringify(manualEditsJsonTemplate, null, 2), |
There was a problem hiding this comment.
can we keep this object as null by default
There was a problem hiding this comment.
if there is an issue with the default value, that should be handled on the frontend the first time it's selected
seveibar
requested changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactored: manual_edit_json template ingestion into db.
included playwright tests
fixes: #261
/claim #261
cc: @seveibar