-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add word wrapping option #89
base: master
Are you sure you want to change the base?
Conversation
This adds a wrap option but does not modify layout (line number column) to not break line number display on wrap (see sample from original issue). |
Would you please post an image showing the difference? |
OK, is there a pure CSS way to achieve this? |
As far as I understand, it would not be possible without changing something in the existing structure, since currently the lines are not even explicitly wrapped in any particular element, meaning that you cannot measure their height or apply selectors to them. The simplest solution would probably be this, which has each line wrapped in a |
@YellowAfterlife: I like that direction a lot more. Would be happy to review a patch on top of this PR to fix the issue. |
YAL-Forks@8fa28b4 |
I don't really want to maintain a fork of the HLJS library so the solution needs to build on top of its quirks. |
Well, you already do, for two years now. Would you want a PR that updates hljs to current version and adds tweaks for line numbers (probably by making a wrapper .js for both background.js and options.js to use) without modifying hljs then? |
@YellowAfterlife: Oh, wow. Memory runs short indeed. Thanks for spotting that. So, yes I'd very much appreciate that contribution. Thank you! |
Fixes #66 and supplants #88.