Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safely update menus in slide-menu service (glimmer compat) #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

iStefo
Copy link

@iStefo iStefo commented Oct 23, 2021

When updating to Ember 3.28, I got the following error involving ember-side-menu:

index.js:181 Uncaught Error: Assertion Failed: You attempted to update [object Object].default to "<(unknown):ember545>", but it is being tracked by a tracking context, such as a template, computed property, or observer. In order to make sure the context updates properly, you must invalidate the property when updating it. You can mark the property as `@tracked`, or use `@ember/object#set` to do this.
    at assert (index.js:181)
    at Object.set [as default] (index.js:899)
    at Class.create (side-menu.js:35)
    at Class._initMenu (side-menu.js:109)
    at Class.didInsertElement (side-menu.js:95)
    at Class.superWrapper [as didInsertElement] (index.js:445)
    at Class.trigger (core_view.js:68)
    at Class.superWrapper [as trigger] (index.js:445)
    at CurlyComponentManager.didCreate (index.js:1178)
    at TransactionImpl.commit (runtime.js:4815)

Using set resolves the issue.

When updating to Ember 3.28, I got the following error involving ember-side-menu:

```
index.js:181 Uncaught Error: Assertion Failed: You attempted to update [object Object].default to "<(unknown):ember545>", but it is being tracked by a tracking context, such as a template, computed property, or observer. In order to make sure the context updates properly, you must invalidate the property when updating it. You can mark the property as `@tracked`, or use `@ember/object#set` to do this.
    at assert (index.js:181)
    at Object.set [as default] (index.js:899)
    at Class.create (side-menu.js:35)
    at Class._initMenu (side-menu.js:109)
    at Class.didInsertElement (side-menu.js:95)
    at Class.superWrapper [as didInsertElement] (index.js:445)
    at Class.trigger (core_view.js:68)
    at Class.superWrapper [as trigger] (index.js:445)
    at CurlyComponentManager.didCreate (index.js:1178)
    at TransactionImpl.commit (runtime.js:4815)
```

Using `set` resolves the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant