Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
hrpc/snapshot: keep version unset if not specified
HBase has 2 snapshot formats: version 0 and version 2. Version 2 is more efficient as it doesn't require the creation of thousand of empty files and instead create a single manifest file[1]. The snapshot format version is dependent of the SnapshotDescription. When the version is not set, HBase will use the default version. In HBase 1.x/2.x, the default version is 2. Unfortunately, gohbase implementation always set the version to 0, even when the caller didn't explicitely set the version. This is is because internally gohbase use an int32 (not a pointer) which default to 0 implicitly. This change switch the internal format to a pointer, to match the "optional" behaviour of the protobuf side. [1] More details at: - https://issues.apache.org/jira/browse/HBASE-7987 - apache/hbase@a669c76
- Loading branch information