Use Revision to detect object changes

tsuru · Aug 29, 2024 · 8e5f5b8 · 8e5f5b8
1 parent e4efbbc
commit 8e5f5b8
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/controllers/validation_controller.go b/controllers/validation_controller.go
@@ -46,12 +46,7 @@ func (r *RpaasValidationReconciler) Reconcile(ctx context.Context, req ctrl.Requ
 		return reconcile.Result{}, err
 	}
 
-	validationHash, err := generateSpecHash(&validation.Spec)
-	if err != nil {
-		return reconcile.Result{}, err
-	}
-
-	if validation.Status.RevisionHash == validationHash && validation.Status.Valid != nil {
+	if validation.Status.ObservedGeneration == validation.ObjectMeta.Generation && validation.Status.Valid != nil {
 		return reconcile.Result{}, nil
 	}
 
@@ -92,6 +87,11 @@ func (r *RpaasValidationReconciler) Reconcile(ctx context.Context, req ctrl.Requ
 		return reconcile.Result{}, err
 	}
 
+	validationHash, err := generateSpecHash(&validation.Spec)
+	if err != nil {
+		return reconcile.Result{}, err
+	}
+
 	pod := newValidationPod(validationMergedWithFlavors, validationHash, plan, configMap)
 
 	existingPod, err := r.getPod(ctx, pod.Namespace, pod.Name)