feat: check for incompatible flavors #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crgisch
force-pushed
the
feat/incompatible-flavors
branch
from
adf9edb
to
366ee4a
Compare
|
LGTM, please don't forget to generate manifests with |
wpjunior
approved these changes
Jan 24, 2024
morpheu
reviewed
Jan 24, 2024
internal/pkg/rpaas/k8s.go
Outdated
| @@ -1289,6 +1289,11 @@ func (m *k8sRpaasManager) validateFlavors(ctx context.Context, instance *v1alpha | |||
| if flavorObj.Spec.CreationOnly && !isCreation { | |||
| return &ValidationError{Msg: fmt.Sprintf("flavor %q can used only in the creation of instance", f)} | |||
| } | |||
|
|
|||
| incompatibleFlavor := checkIncompatibleFlavors(flavorObj.Spec.IncompatibleFlavors, flavors) | |||
There was a problem hiding this comment.
I think is just cosmetic, but would be nice bring error message inside checkIncompatibleFlavors and throw it instead a string to be more golang way to handle error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.