Add support for local/remote binary #52

frankois944 · 2024-11-27T20:31:59Z

Based on #47

Add the capability to use local and remote Binary

Test are updated
A local xcframework (for local) and a zipped (for remote) one is available in the resource folder or the test module.

The folder localBinarySample contains the Xcode project and a script to generate the testing framework.

For VersionRange, it's not possible to have a specific one We need to try/cacth every swift step and print on the ouput the error, it's important for the user All test are passing except local package The local package need to be done

we can now use local path, some manual update has been done all tests are passing

add new test for building and liking Firebase using triple for specify the build target

you can set multiple product from a dependency like Firebase

need to duplicate the code of remote function The exception is not forwarded correctly

check case when the list of packages have a empty string add some comment for the versioning of package

update comment in interface

We can now set the toolsVersion from the plugin By default, the command line uses the latest swift version available. By at some cases, it can't work and a specific version need to be set.

It needs to be set at Warning Level or it will be considered as a Error.

set a non null default value for toolsVersion in CompileTask

rollback unwanted commit change

commit 166468f Author: frankois <dabonot.francois@gmail.com> Date: Wed Nov 6 17:27:43 2024 +0100 cleaning CompileSwiftTask moving all command for updating the manifest to CreatePackageSwift

update sed command for injecting the package cleaning some code

the checksum is a mandatory value

update checksum update build script

use template now

…l' of https://github.com/frankois944/swift-klib-plugin into swift-spm-local-remote-lib # Conflicts: # plugin/src/functionalTest/kotlin/io/github/ttypic/swiftklib/gradle/SwiftPackageModulesTest.kt # plugin/src/main/kotlin/io/github/ttypic/swiftklib/gradle/api/SwiftPackageConfiguration.kt # plugin/src/main/kotlin/io/github/ttypic/swiftklib/gradle/internal/SwiftPackageConfigurationImpl.kt # plugin/src/main/kotlin/io/github/ttypic/swiftklib/gradle/task/CompileSwiftTask.kt # plugin/src/main/kotlin/io/github/ttypic/swiftklib/gradle/templates/CreatePackageSwift.kt

frankois944 · 2024-11-27T20:32:40Z

@IlyaGulya Done, the history is dirty, squash if you can :D

IlyaGulya · 2024-11-28T05:46:22Z

Hmm, I'm not sure I want binaries in the repo.
I think we could compile these frameworks during the test execution and put them where required

IlyaGulya · 2024-11-28T05:47:11Z

Also, I think it would be nice to use Xcodegen to avoid putting xcode project files into repo. They are not git-friendly =)

frankois944 · 2024-11-28T07:11:46Z

Hmm, I'm not sure I want binaries in the repo. I think we could compile these frameworks during the test execution and put them where required

There are required for testing, especially the .zip one, it needs to be remotly available and have a valid checksum. It can't be done during the tests.
Both case are necessary and take a LOT of time to build.

frankois944 · 2024-11-28T07:15:53Z

Also, I think it would be nice to use Xcodegen to avoid putting xcode project files into repo. They are not git-friendly =)

Using an external tools to manage the Xcode project will make thing more complicate to manage.
But yes, not git friendly, like every Apple project. But once it's inside the git, it won't move until we add more cases.

Just stay on the simplest way, I can also put the sample project in a zip to clean the history of the git, If you want.

IlyaGulya · 2024-11-28T14:22:49Z

Maybe we can use some community built binary framework for such tests?

IlyaGulya · 2024-11-28T14:29:17Z

Regarding the xcodeproj - i don't really see any specific reason to keep whole xcode project in the repo, when it can be easily generated by xcodegen.
It's clean and maintainable

name: DummyFramework
options:
  deploymentTarget:
    iOS: 12.0
    macOS: 11.0
    tvOS: 15.0
    watchOS: 8.0
  xcodeVersion: "16.1"
  preferredProjectObjectVersion: "77"

targets:
  DummyFramework:
    type: framework
    platform: [iOS, macOS, tvOS, watchOS]
    sources: 
      - DummyFramework
    settings:
      base:
        PRODUCT_BUNDLE_IDENTIFIER: com.dummy.DummyFramework
        BUILD_LIBRARY_FOR_DISTRIBUTION: YES
        SWIFT_INSTALL_OBJC_HEADER: NO
        DEFINES_MODULE: YES
        SWIFT_VERSION: 5.0
        CURRENT_PROJECT_VERSION: 1
        MARKETING_VERSION: 1.0
        SUPPORTS_MACCATALYST: YES
        SUPPORTS_MAC_DESIGNED_FOR_IPHONE_IPAD: YES
        SUPPORTS_XR_DESIGNED_FOR_IPHONE_IPAD: NO
        DRIVERKIT_DEPLOYMENT_TARGET: 20.0
        SKIP_INSTALL: YES

markst · 2024-12-11T07:28:24Z

May be relevant: PaGr0m/kotlin-spm-plugin#7

frankois944 added 30 commits November 3, 2024 20:20

using command line instead of string manipulation

0a6693c

For VersionRange, it's not possible to have a specific one We need to try/cacth every swift step and print on the ouput the error, it's important for the user All test are passing except local package The local package need to be done

fix local spm

3f7ae02

we can now use local path, some manual update has been done all tests are passing

make the plugin working namespace

b47ec30

add new test for building and liking Firebase using triple for specify the build target

WIP: add multi product usage for a SPM repository

8e39b53

you can set multiple product from a dependency like Firebase

fix test

c96f686

need to duplicate the code of remote function The exception is not forwarded correctly

fix test

f3dcc6a

check case when the list of packages have a empty string add some comment for the versioning of package

Merge branch 'ttypic:main' into external-deps-with-command-line

7101138

update remote parameter name

53cf471

update comment in interface

add more complex case

de4969e

Add tools version parameter

23a5847

We can now set the toolsVersion from the plugin By default, the command line uses the latest swift version available. By at some cases, it can't work and a specific version need to be set.

Change ExperimentalSwiftklibApi level

3711eb8

It needs to be set at Warning Level or it will be considered as a Error.

fix build (my bad)

b6427ad

set a non null default value for toolsVersion in CompileTask

rollback bad commit

08941f5

rollback unwanted commit change

Squashed commit of the following:

71a9d4e

commit 166468f Author: frankois <dabonot.francois@gmail.com> Date: Wed Nov 6 17:27:43 2024 +0100 cleaning CompileSwiftTask moving all command for updating the manifest to CreatePackageSwift

work in progress

e999959

fix local package declaration

8864fbf

update sed command for injecting the package cleaning some code

fix test

8fa857f

update binarytarget

bfe0594

the checksum is a mandatory value

update tests

10cc56a

update dummy binary

4d47c54

update gitignore

9602c7c

remove extra text

e58d0c3

update test remote binary

19c8571

update checksum update build script

rework local/remote binary

213c1fb

use template now

rollback some useless change

a83b852

rollback some useless change

1d1b3fd

rollback some useless change

b556d90

rollback some useless change

0df4a18

continue cleaning

931e265

use correct way to check error

3f276d4

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for local/remote binary #52

Add support for local/remote binary #52

frankois944 commented Nov 27, 2024

frankois944 commented Nov 27, 2024

IlyaGulya commented Nov 28, 2024

IlyaGulya commented Nov 28, 2024

frankois944 commented Nov 28, 2024 •

edited

Loading

frankois944 commented Nov 28, 2024 •

edited

Loading

IlyaGulya commented Nov 28, 2024

IlyaGulya commented Nov 28, 2024

markst commented Dec 11, 2024

Add support for local/remote binary #52

Are you sure you want to change the base?

Add support for local/remote binary #52

Conversation

frankois944 commented Nov 27, 2024

frankois944 commented Nov 27, 2024

IlyaGulya commented Nov 28, 2024

IlyaGulya commented Nov 28, 2024

frankois944 commented Nov 28, 2024 • edited Loading

frankois944 commented Nov 28, 2024 • edited Loading

IlyaGulya commented Nov 28, 2024

IlyaGulya commented Nov 28, 2024

markst commented Dec 11, 2024

frankois944 commented Nov 28, 2024 •

edited

Loading

frankois944 commented Nov 28, 2024 •

edited

Loading